You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
swoole thread mode (multi-threading) requires ZTS. Our chosen swoole-thread and thread-context are mutually exclusive, because thread-context uses process-global state (a single lock and reactor pointer), which conflicts with multi-reactor thread mode. For NTS builds, just use the upstream default (boost asm context): it is faster and better tested.
Enabling thread-context on NTS is known to cause segfaults, e.g. Process::signal() in onManagerStart. I will submit the real patch upstream later.
Checklist before merging
If you modified *.php or *.yml, run them locally to ensure your changes are valid:
Looks like --enable-thread-context is slower than --disable-thread-context. Its more suitable for debugging compatibility, so even if the upstream is fixed, continuing to use --disable-thread-context on NTS is still the correct choice (config.m4 also disables it by default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-testThis PR has not been tested yet, cannot merge now
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
swoole thread mode (multi-threading) requires ZTS. Our chosen swoole-thread and thread-context are mutually exclusive, because thread-context uses process-global state (a single lock and reactor pointer), which conflicts with multi-reactor thread mode. For NTS builds, just use the upstream default (boost asm context): it is faster and better tested.
Enabling thread-context on NTS is known to cause segfaults, e.g. Process::signal() in onManagerStart. I will submit the real patch upstream later.
Checklist before merging
*.phpor*.yml, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:lint-config